Fix false positive tracer leaks in flax library. #4232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_679881642
branch
3 times, most recently
from
7de8b3d to
504cd3e
Compare
We'd like flax itself never to accidentally trigger the jax leak detector when enabled, but over the years a few longer-lived temporaries were introduced to the flax codebase that do trigger it. We remedy those cases: - in flax.core remove a redundant use of nonlocal scopes in pack implementation. - for nn.jit have the hashing helper datastructure maintain a weakref to module. - explicitly exempt a context capture used in module summary tabulation routine. PiperOrigin-RevId: 680626207
copybara-service
bot
force-pushed
the
test_679881642
branch
from
504cd3e to
62a6a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix false positive tracer leaks in flax library.
We'd like flax itself never to accidentally trigger the jax leak detector when enabled,
but over the years a few longer-lived temporaries were introduced to the flax codebase
that do trigger it. We remedy those cases: