Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titillium Web: v3.000 variable fonts added #1806

Closed
wants to merge 9 commits into from

Conversation

eliheuer
Copy link
Collaborator

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 11, 2019

@m4rc1e m4rc1e added the III VF Replacement Replace an existing family of static fonts with variable fonts label Jan 11, 2019
@eliheuer
Copy link
Collaborator Author

eliheuer commented Mar 29, 2019

@m4rc1e I added a new regular variable font file TitilliumWeb[wght].ttf conforming to the new name spec discussed here: #1817 (comment)

Built from the upstream repo: eliheuer/titillium-web-vf@c718586

Fontbakery report

Fontbakery version: 0.7.0

[4] TitilliumWeb.wght..ttf
🔥 FAIL: Checking file is named canonically.
🔥 FAIL: Checking with ots-sanitize.

ERROR: GDEF: bad caret value format: 3
ERROR: GDEF: Invalid ligature caret list
ERROR: GDEF: Failed to parse table
Failed to sanitize file!

WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
WARN: Check for points out of bounds.
  • com.google.fonts/check/points_out_of_bounds
  • WARN The following glyphs have coordinates which are out of bounds:
    [('uni066C', 44.0572, -122.4099), ('uni066C', 75.6118, 35.3631), ('uni066C', 105.6638, 35.3631), ('uni066C', 67.3475, -122.4099), ('quotesinglbase', 121.2, 114.85), ('quotedblbase', 247.2, 108.85), ('quotedblleft', 273.14588, 727.1452), ('quotedblleft', 243.65775, 727.1452), ('quotedblleft', 140.14588, 727.1452), ('quotedblleft', 110.65775, 727.1452), ('quotedblright', 62.85412, 526.8548), ('quotedblright', 92.34225, 526.8548), ('quotedblright', 206.85412, 526.8548), ('quotedblright', 236.34225, 526.8548), ('quoteleft', 140.2, 726.85), ('quoteright', 62.8, 527.15), ('approxequal', 492.465, 329.0), ('approxequal', 492.465, 167.0)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
0 2 2 53 6 87
0% 1% 1% 35% 4% 58%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

@eliheuer
Copy link
Collaborator Author

eliheuer commented Mar 29, 2019

I also added a new italic variable font file TitilliumWeb-Italic[wght].ttf conforming to the new name spec. Built from the upstream repo: eliheuer/titillium-web-vf@79ca746

Fontbakery report

Fontbakery version: 0.7.0

[4] TitilliumWeb-Italic.wght..ttf
🔥 FAIL: Checking file is named canonically.
🔥 FAIL: Checking with ots-sanitize.

ERROR: GDEF: bad caret value format: 3
ERROR: GDEF: Invalid ligature caret list
ERROR: GDEF: Failed to parse table
Failed to sanitize file!

WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
WARN: Check for points out of bounds.
  • com.google.fonts/check/points_out_of_bounds
  • WARN The following glyphs have coordinates which are out of bounds:
    [('uni066B', 98.5142, 83.0), ('uni066B', 187.34539999999998, -129.0), ('uni066C', 113.68809999999999, 32.3579), ('uni066C', 143.74009999999998, 32.3579), ('uni066C', 180.4375, -126.9177), ('uni060C', 173.48579999999998, 0.0), ('uni060C', 84.65460000000002, 212.0), ('approxequal', 124.65499999999997, 327.0), ('approxequal', 124.65499999999997, 165.0)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
0 2 2 53 6 87
0% 1% 1% 35% 4% 58%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

@eliheuer eliheuer requested a review from m4rc1e March 29, 2019 05:19
@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 11, 2019

You can find the results of this pr here.

@eliheuer
can you rename the fonts in the following manner

You'll then need to set the fsSelection to 200.

Once we've done this I'd like to push the fonts to sandbox and do further functional tests.

@eliheuer
Copy link
Collaborator Author

I split this PR into two (roman, italic) new style PRs (for using GF bot). I'm closing work here and moving to the new PRs:

Roman: #1987
Italic: #1988

@eliheuer eliheuer closed this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
III VF Replacement Replace an existing family of static fonts with variable fonts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants