-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cactus Classical Serif: Version 1.000 added #7665
Conversation
Taken from the upstream repo https://github.com/aaronbell/CactusSerif at commit aaronbell/CactusSerif@eb5a6ea.
(btw, the description is translated from the upstream repro. Might be good to replace?) |
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] CactusClassicalSerif-Regular.ttfAll other checks[26] CactusClassicalSerif-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif' and OFL text has 'https://github.com/MoonlitOwen/CactusSerif' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL DESCRIPTION.en_us.html must have more than 200 bytes.
🔥 FAIL Is this a proper HTML snippet?
🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 5 | 15 | 72 | 9 | 150 | 0 |
0% | 0% | 2% | 6% | 29% | 4% | 60% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
OK!
Added
Yeah....
Yes. The font covers Latin Kernal, which has been confirmed as OK
Ideally there should be kerning data for the non-CJK components, but as the font's intended purpose is for TC, I think it is OK to let this one go.
I'm not particularly concerned about these. |
Fixed the glyphs with zero width where the glyph was set out to the right side. |
Updated TTF and metadata bits
Updated! BTW, I'm not seeing that |
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] CactusClassicalSerif-Regular.ttfAll other checks[24] CactusClassicalSerif-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif' and OFL text has 'https://github.com/MoonlitOwen/CactusSerif' [code: mismatch]🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 15 | 69 | 9 | 155 | 0 |
0% | 0% | 1% | 6% | 27% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Co-authored-by: Henry Chan <hfhchan@users.noreply.github.com>
@aaronbell ah sorry! the 'o' issue is in that glyphs: uni3375 |
@aaronbell Mmh, then I would advice to let Moonlit repo everywhere, to avoid fails like this:
|
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] CactusClassicalSerif-Regular.ttfAll other checks[24] CactusClassicalSerif-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif', OFL text has 'https://github.com/MoonlitOwen/CactusSerif' and HTML description has 'github.com/MoonlitOwen/CactusSerif' [code: mismatch]🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 15 | 69 | 10 | 155 | 0 |
0% | 0% | 1% | 6% | 27% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Correcting oV glyph
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] CactusClassicalSerif-Regular.ttfAll other checks[24] CactusClassicalSerif-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif', OFL text has 'https://github.com/MoonlitOwen/CactusSerif' and HTML description has 'github.com/MoonlitOwen/CactusSerif' [code: mismatch]🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 15 | 69 | 10 | 155 | 0 |
0% | 0% | 1% | 6% | 27% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://github.com/aaronbell/CactusSerif at commit aaronbell/CactusSerif@eb5a6ea.
PR Checklist: