blob: include key in error messages #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangent
commented
Jul 16, 2019
| @@ -768,8 +772,6 @@ func (b *Bucket) NewWriter(ctx context.Context, key string, opts *WriterOptions) | |||
| end: end, | |||
| cancel: cancel, | |||
| key: key, | |||
| opts: dopts, | |||
There was a problem hiding this comment.
These two fields (along with ctx) are only supposed to be set when we need to call NewTypedWriter later; they are explicitly set in the else a few lines down. I'm not sure why we were setting them here, they are not needed and it made the code unclear because the comment in the struct says they are only set when w is nil.
I removed them and clarified the comments.
Codecov Report
@@ Coverage Diff @@
## master #2565 +/- ##
==========================================
+ Coverage 66.65% 66.71% +0.06%
==========================================
Files 133 133
Lines 15489 15488 -1
==========================================
+ Hits 10324 10333 +9
+ Misses 4398 4387 -11
- Partials 767 768 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2564.
See the bug for context. TL;DR, services don't usually include the key in error messages (e.g., "The specified key does not exist" without saying what the key was). That lack of info can make debugging difficult. This PR adds the key (where possible) to error messages from
blob, via the portable type.For example, the GCS error for a missing blob was:
blob (code=NotFound): storage: object doesn't existand after this change it is:
blob (key not-found) (code=NotFound): storage: object doesn't existI also added a conformance test for
Bucket.Attributesfor a nonexistent key.