Skip to content

Teams.CreateOrUpdateIDPGroupConnections and Teams.ListIDPGroupsForTeam generating requests resulting in 404s #1483

@anGie44

Description

@anGie44

github version: v29.0.3

While trying to create Idp Group connections for my team, I am receiving 404 errors when using the method CreateOrUpdateIDPGroupConnections. In the logs attached, you can see the PATCH request is made with PATCH /teams/test-team/team-sync/group-mappings however according to the api docs (https://developer.github.com/v3/teams/team_sync/#create-or-update-idp-group-connections), the call is to be prefixed with /orgs/:org and from what I can see in github.go these requests do not handle prepending this prefix. As an alternative, I tried to directly hit the api endpoint in my browser using https://api.github.com/orgs/test-org/teams/test-team/team-sync/group-mappings and this correctly returned with an empty groups object as expected as my github team doesn't have any particular Identity Provider Groups set at the moment:

{
  "groups": [

  ]
}

I expect the request generated when using Teams.ListIDPGroupsForTeam will result in a similar 404 as the method creates a GET request without prepending the orgs/:org prefix to the url

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions