Skip to content

Conversation

fiahil
Copy link
Contributor

@fiahil fiahil commented Jul 2, 2019

Hello,
This PR adds methods for Github Enterprise endpoints.

The following are covered:

  • Create organization
  • Create User
  • Delete User

I will be happy to add a few fix on this PR if necessary.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #1214 into master will decrease coverage by 0.04%.
The diff coverage is 65.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
- Coverage   73.39%   73.34%   -0.05%     
==========================================
  Files          84       86       +2     
  Lines        5949     5984      +35     
==========================================
+ Hits         4366     4389      +23     
- Misses        825      831       +6     
- Partials      758      764       +6
Impacted Files Coverage Δ
github/admin_stats.go 100% <ø> (ø) ⬆️
github/admin_users.go 63.63% <63.63%> (ø)
github/admin_orgs.go 69.23% <69.23%> (ø)
github/users_emails.go 58.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffc27d...52819cb. Read the comment docs.

add create organization method for Admin API

add GHE admin create user

add GHE admin create impersonation token

add DeleteUser endpoint to go-github

Co-authored-by: Quentin Leffray <fiahil@users.noreply.github.com>
Co-authored-by: David Dumas <Misteur-Z@users.noreply.github.com>
Co-authored-by: Clement Roche <roche-d@users.noreply.github.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@MaesterZ
Copy link

MaesterZ commented Jul 2, 2019

Ok for my commits being contributed to this project 👍

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, contributors.
We need to make a few changes before this can be merged, please.

@willnorris - can you please check the status of the CLA with the 3 authors and advise if this PR can be accepted?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, @fiahil!
Just one more tweak, please, and then we should be good to go after we get a second LGTM and @willnorris reports back about the CLA status.

@gmlewis gmlewis requested a review from gauntface July 4, 2019 12:54
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fiahil!
LGTM.

Awaiting second LGTM and CLA status report.

@willnorris willnorris added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Jul 8, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 8, 2019

Thank you, @gauntface!
Merging.

@gmlewis gmlewis merged commit cad32f2 into google:master Jul 8, 2019
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants