-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add methods for GHE endpoints #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 73.39% 73.34% -0.05%
==========================================
Files 84 86 +2
Lines 5949 5984 +35
==========================================
+ Hits 4366 4389 +23
- Misses 825 831 +6
- Partials 758 764 +6
Continue to review full report at Codecov.
|
add create organization method for Admin API add GHE admin create user add GHE admin create impersonation token add DeleteUser endpoint to go-github Co-authored-by: Quentin Leffray <fiahil@users.noreply.github.com> Co-authored-by: David Dumas <Misteur-Z@users.noreply.github.com> Co-authored-by: Clement Roche <roche-d@users.noreply.github.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Ok for my commits being contributed to this project 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, contributors.
We need to make a few changes before this can be merged, please.
@willnorris - can you please check the status of the CLA with the 3 authors and advise if this PR can be accepted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, @fiahil!
Just one more tweak, please, and then we should be good to go after we get a second LGTM and @willnorris reports back about the CLA status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @fiahil!
LGTM.
Awaiting second LGTM and CLA status report.
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Thank you, @gauntface! |
Hello,
This PR adds methods for Github Enterprise endpoints.
The following are covered:
I will be happy to add a few fix on this PR if necessary.