Update git_refs.go #1240
Merged
Update git_refs.go #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a segfault when fetching refs from github returns an error (say due to connectivity)
googlebot
added
the
cla: yes
github client returns a response _and_ error when the status code is 404 (in contrast to the standard http.Client)
be consistent with other parts of the github client returning the response && error
Fix syntax error and remind self to stop using GitHub editor
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 86 86
Lines 6026 6026
=======================================
Hits 4421 4421
Misses 836 836
Partials 769 769
Continue to review full report at Codecov.
|
@gmlewis I was only playing with this part of the API - so there may be similar issues in other calls? Also feel free to squash the commits on merge :) |
gauntface
approved these changes
Sep 6, 2019
|
Thank you, @gauntface! |
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a segfault when fetching refs from github returns an error (say due to connectivity)