Skip to content

remove blob_href from check annotations #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2019
Merged

remove blob_href from check annotations #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fc9872
remove blob_href from check annotations
mcristina422 Jul 26, 2019
b532214
fix test case
mcristina422 Jul 27, 2019
72b0eec
Merge branch 'master' into removeHref
gmlewis Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion github/checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ type CheckRunOutput struct {
// CheckRunAnnotation represents an annotation object for a CheckRun output.
type CheckRunAnnotation struct {
Path *string `json:"path,omitempty"`
BlobHRef *string `json:"blob_href,omitempty"`
StartLine *int `json:"start_line,omitempty"`
EndLine *int `json:"end_line,omitempty"`
StartColumn *int `json:"start_column,omitempty"`
Expand Down
4 changes: 0 additions & 4 deletions github/checks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ func TestChecksService_ListCheckRunAnnotations(t *testing.T) {
})
fmt.Fprint(w, `[{
"path": "README.md",
"blob_href": "https://github.com/octocat/Hello-World/blob/837db83be4137ca555d9a5598d0a1ea2987ecfee/README.md",
"start_line": 2,
"end_line": 2,
"start_column": 1,
Expand All @@ -167,7 +166,6 @@ func TestChecksService_ListCheckRunAnnotations(t *testing.T) {

want := []*CheckRunAnnotation{{
Path: String("README.md"),
BlobHRef: String("https://github.com/octocat/Hello-World/blob/837db83be4137ca555d9a5598d0a1ea2987ecfee/README.md"),
StartLine: Int(2),
EndLine: Int(2),
StartColumn: Int(1),
Expand Down Expand Up @@ -506,7 +504,6 @@ func Test_CheckRunMarshal(t *testing.T) {
Annotations: []*CheckRunAnnotation{
{
AnnotationLevel: String("a"),
BlobHRef: String("b"),
EndLine: Int(1),
Message: String("m"),
Path: String("p"),
Expand Down Expand Up @@ -598,7 +595,6 @@ func Test_CheckRunMarshal(t *testing.T) {
"annotations": [
{
"path": "p",
"blob_href": "b",
"start_line": 1,
"end_line": 1,
"annotation_level": "a",
Expand Down
8 changes: 0 additions & 8 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.