Skip to content

Conversation

wesleimp
Copy link
Collaborator

Delete a commit comment reaction

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @wesleimp!

I think we should also add a new DeleteCommentReactionByRepoID method in this same PR which supports the comment in the docs that says:

Note: You can also specify a repository by repository_id using the route DELETE /repositories/:repository_id/comments/:comment_id/reactions/:reaction_id.

You can either call out to a private method where these two public methods just generate the URL and pass it to the private method that does the rest (which I personally prefer), or just have to fully complete public methods. Your choice.

@wesleimp
Copy link
Collaborator Author

Thank you, @wesleimp!

I think we should also add a new DeleteCommentReactionByRepoID method in this same PR which supports the comment in the docs that says:

Note: You can also specify a repository by repository_id using the route DELETE /repositories/:repository_id/comments/:comment_id/reactions/:reaction_id.

You can either call out to a private method where these two public methods just generate the URL and pass it to the private method that does the rest (which I personally prefer), or just have to fully complete public methods. Your choice.

@gmlewis I think now the changes are ok

@wesleimp wesleimp requested a review from gmlewis February 28, 2020 15:15
@gmlewis gmlewis changed the title Added support to delete commit comment reaction Add support to delete commit comment reaction Feb 28, 2020
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @wesleimp!
LGTM.

Please make sure to sign the Google CLA, and then we will be ready for a second LGTM before merging.

@gmlewis gmlewis requested a review from gauntface February 28, 2020 15:41
@wesleimp
Copy link
Collaborator Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Feb 28, 2020
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 28, 2020

@martinssipenko - if you feel like reviewing and approving, your help would be greatly appreciated!

Copy link
Contributor

@martinssipenko martinssipenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 1, 2020

Thank you, @martinssipenko !
Merging.

@gmlewis gmlewis merged commit d913de9 into google:master Mar 1, 2020
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 1, 2020

Relates to: #1442.

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants