-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add support to delete commit comment reaction #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @wesleimp!
I think we should also add a new DeleteCommentReactionByRepoID
method in this same PR which supports the comment in the docs that says:
Note: You can also specify a repository by repository_id using the route DELETE /repositories/:repository_id/comments/:comment_id/reactions/:reaction_id.
You can either call out to a private method where these two public methods just generate the URL and pass it to the private method that does the rest (which I personally prefer), or just have to fully complete public methods. Your choice.
@gmlewis I think now the changes are ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @wesleimp!
LGTM.
Please make sure to sign the Google CLA, and then we will be ready for a second LGTM before merging.
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@martinssipenko - if you feel like reviewing and approving, your help would be greatly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @martinssipenko ! |
Relates to: #1442. |
Delete a commit comment reaction
DELETE /repos/:owner/:repo/comments/:comment_id/reactions/:reaction_id