Implement support for update pages API #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements support for updating Github Pages sites - allowing CName and Source to be customized.
googlebot
added
the
cla: yes
gmlewis
requested changes
Mar 5, 2020
There was a problem hiding this comment.
Thank you, @patrickmarabeas!
Just a few changes, please.
Please make sure to run:
go generate ./...
go test ./...
go vet ./...and commit and push the results (no force push, please... we squash the commits anyway).
gmlewis
reviewed
Mar 5, 2020
gmlewis
reviewed
Mar 5, 2020
gmlewis
reviewed
Mar 5, 2020
gmlewis
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Thank you, @patrickmarabeas!
This looks great.
Awaiting second LGTM before merging.
|
Thank you, @wesleimp! Merging. |
sprsld
pushed a commit
to sprsld/go-github
that referenced
this pull request
Mar 24, 2020
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for updating Github Pages sites - allowing CName and
Source to be customized.
Fixes: #1361