Skip to content

Conversation

suhaibmujahid
Copy link
Contributor

In the pull request #1178, the behavior on the client instantiation change to use a new http.Client instead of using the http.DefaultClient. This change is reflected in the comment block for NewClient but not for NewEnterpriseClient .

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1464 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files          94       94           
  Lines        8419     8419           
=======================================
  Hits         5739     5739           
  Misses       1819     1819           
  Partials      861      861           
Impacted Files Coverage Δ
github/github.go 89.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5442b7...28538bc. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @suhaibmujahid!
LGTM.
Merging.

@gmlewis gmlewis merged commit 7726a3e into google:master Mar 19, 2020
@suhaibmujahid suhaibmujahid deleted the patch-1 branch March 19, 2020 23:54
sprsld pushed a commit to sprsld/go-github that referenced this pull request Mar 24, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants