Skip to content

Conversation

patrickmarabeas
Copy link
Contributor

@patrickmarabeas patrickmarabeas commented Mar 24, 2020

Implements support for specifying a repositories visibility. It can be
one of public, private or internal (if the organization is associated
with an enterprise account).

The associated preview header (nebula) has also been added.

Resolves: #1470

Implements support for specifying a repositories visibility. It can be
one of public, private or internal (if the organization is associated
with an enterprise account).

The associated preview header (nebula) has also been added.
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1471 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
+ Coverage   68.16%   68.17%   +0.01%     
==========================================
  Files          94       94              
  Lines        8419     8422       +3     
==========================================
+ Hits         5739     5742       +3     
  Misses       1819     1819              
  Partials      861      861              
Impacted Files Coverage Δ
github/github.go 89.77% <ø> (ø)
github/repos.go 69.81% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7726a3e...c414f9d. Read the comment docs.

@patrickmarabeas
Copy link
Contributor Author

What is the release cadence for this project - I would like to put this to use in the Github Terraform Provider ASAP!

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 24, 2020

We used to do a semver (major, minor, patch) release on each merged PR, but that got way too extreme... so now we release on demand. I can make a new release after this PR is merged.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @patrickmarabeas!
LGTM.

Awaiting second LGTM before merging.

Note to self: this is a non-breaking API change, and adds backward-compatible functionality, so this will be a minor release.

@gmlewis gmlewis requested review from gauntface and wesleimp March 24, 2020 21:55
@patrickmarabeas
Copy link
Contributor Author

That would be great - thanks @gmlewis!

Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 25, 2020

Thank you, @wesleimp!
Merging, then making a minor release.

@gmlewis gmlewis merged commit 371b000 into google:master Mar 25, 2020
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 25, 2020

@patrickmarabeas - Version v30.1.0 has now been released at your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for visibility parameter when creating / editing repository
4 participants