Skip to content

Conversation

nightlark
Copy link
Contributor

@nightlark nightlark commented Apr 22, 2020

Adds support for the new endpoint added to delete logs.

Doc link: https://developer.github.com/v3/actions/workflow-runs/#delete-workflow-run-logs

Fixes #1500.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #1501 into master will decrease coverage by 0.15%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   68.19%   68.04%   -0.16%     
==========================================
  Files          94       94              
  Lines        8452     8534      +82     
==========================================
+ Hits         5764     5807      +43     
- Misses       1819     1845      +26     
- Partials      869      882      +13     
Impacted Files Coverage Δ
github/actions_workflow_runs.go 58.13% <62.50%> (+0.44%) ⬆️
github/actions_runners.go 51.35% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7623a89...ba5fed3. Read the comment docs.

@nightlark nightlark marked this pull request as draft April 22, 2020 07:36
@nightlark nightlark marked this pull request as ready for review April 25, 2020 15:24
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nightlark!
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested review from gauntface and wesleimp April 25, 2020 16:31
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 28, 2020

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit b14be9f into google:master Apr 28, 2020
@nightlark nightlark deleted the add-delete-actions-logs branch April 29, 2020 00:01
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for deleting workflow run logs
5 participants