Skip to content

Conversation

AntonNguyen
Copy link
Contributor

@AntonNguyen AntonNguyen commented Aug 31, 2020

I noticed that the github client hadn't added support for this functionality yet.

According to https://docs.github.com/en/rest/reference/actions#create-a-workflow-dispatch-event, this endpoint is utilized for manually triggering a Github Actions workflow run.

I purposely left out support for the inputs key, since due to its dynamic nature, might be a larger and more complicated change than we want.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #1623 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   68.06%   68.09%   +0.02%     
==========================================
  Files          97       97              
  Lines        8855     8863       +8     
==========================================
+ Hits         6027     6035       +8     
  Misses       1912     1912              
  Partials      916      916              
Impacted Files Coverage Δ
github/actions_workflows.go 66.12% <100.00%> (+5.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a3a8...f02e209. Read the comment docs.

@AntonNguyen AntonNguyen force-pushed the add-dispatch-support branch from 4b9d962 to 99788a1 Compare August 31, 2020 23:05
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonNguyen!
Just a few changes, please, and then we should be ready for a second review before merging.

@gmlewis gmlewis requested a review from wesleimp September 1, 2020 01:51
@AntonNguyen AntonNguyen requested a review from gmlewis September 1, 2020 03:29
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonNguyen !
LGTM.

Awaiting second LGTM before merging.

Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonNguyen
LGTM 👌🏼

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 1, 2020

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit abd5d02 into google:master Sep 1, 2020
@AntonNguyen AntonNguyen deleted the add-dispatch-support branch September 1, 2020 23:23
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants