Skip to content

Bump version of go-github library #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Bump version of go-github library #1660

merged 2 commits into from
Dec 2, 2020

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Dec 2, 2020

This PR is in preparation for release v33.0.0.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #1660 (0f6a70f) into master (98b466b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1660   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files          98       98           
  Lines        6377     6377           
=======================================
  Hits         4464     4464           
  Misses        991      991           
  Partials      922      922

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b466b...0f6a70f. Read the comment docs.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 2, 2020

@erikkn or @nightlark or @wesleimp - please review when you have a moment. Thank you!

@nightlark
Copy link
Contributor

Does scrape need updating from v32 to v33 now, or will that get done later?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 2, 2020

@nightlark - scrape will be updated later, as it depends on an already-released version of this library.

nightlark
nightlark approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@nightlark nightlark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 2, 2020

Thank you, @nightlark !
Merging.

@gmlewis gmlewis merged commit 6c3a8a1 into google:master Dec 2, 2020
@gmlewis gmlewis deleted the release-v33 branch December 2, 2020 18:01
@erikkn
Copy link
Contributor

erikkn commented Dec 2, 2020

Thanks @gmlewis for all the work and for getting this released so fast!

@erikkn erikkn mentioned this pull request Dec 4, 2020
Merged
vchudnov-g added a commit to vchudnov-g/google-cloud-go that referenced this pull request Dec 7, 2020
@vchudnov-g
chore: Bump version of go-github library to v33
d43b2a3 
(see google/go-github#1660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nightlark nightlark nightlark approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmlewis @nightlark @erikkn