Skip to content

Conversation

jacobfoard
Copy link

It looks like the docs got updated recently to include these additional fields.

Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com>
@google-cla
Copy link

google-cla bot commented Mar 31, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1839 (9b47a36) into master (3130b78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1839   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         104      104           
  Lines        6602     6602           
=======================================
  Hits         6441     6441           
  Misses         87       87           
  Partials       74       74           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3130b78...9b47a36. Read the comment docs.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 31, 2021

Thank you, @jacobfoard !
This is also a tiny PR... let me know if you would like me to do something similar to how we handled #1837, although I'm happy to wait for the full process.

@jacobfoard
Copy link
Author

@gmlewis That'd be swell. I made the fork for the org anticipating the PR to sit for a bit 😅, so thanks for exceeding expectations and being quick on the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants