Skip to content

Conversation

itsmatinx
Copy link
Contributor

Resolves #1812

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 8, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @itsmatinx !
Just a few minor tweaks, please, and also please run go generate ./... and push the changes (please do not force push) to this PR (as described in our CONTRIBUTING.md doc).

@itsmatinx
Copy link
Contributor Author

Thank you, @itsmatinx !
Just a few minor tweaks, please, and also please run go generate ./... and push the changes (please do not force push) to this PR (as described in our CONTRIBUTING.md doc).

Thank you for reviewing the PR. I read the CONTRIBUTING.md previously, but I misunderstood the generated files. I thought it would be enough to run go generate ./... and simply make sure everything works.

The requested changes have also been resolved.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #1871 (4c81bb3) into master (a19996a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1871   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6771     6783   +12     
=======================================
+ Hits         6612     6624   +12     
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/teams.go 98.09% <ø> (ø)
github/orgs_members.go 98.52% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19996a...4c81bb3. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @itsmatinx !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp May 8, 2021 20:08
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator

gmlewis commented May 12, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit d39b94d into google:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrganizationsService.ListFailedOrgInvitations
3 participants