Skip to content

Conversation

slayer321
Copy link
Contributor

@gmlewis
I have added the changes required for issue #1881
I had run go test ./... before and after the changes. I could see all test cases passing in /github folder.

Thanks,

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1896 (cb65de3) into master (75644ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1896   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6786     6786           
=======================================
  Hits         6627     6627           
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/pulls.go 97.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75644ea...cb65de3. Read the comment docs.

@gmlewis gmlewis changed the title added auto_merge field in PullRequest struct Add auto_merge field in PullRequest struct Jun 16, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @slayer321!
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp June 16, 2021 14:40
@gmlewis
Copy link
Collaborator

gmlewis commented Jun 24, 2021

Friendly ping @wesleimp

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit a0bec87 into google:master Jul 8, 2021
@simongottschlag
Copy link

Woop woop! Thank you @slayer321 @gmlewis @Parker77 😁🥇🎉🚀

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 9, 2021

Fixes: #1881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants