Modify GetBranch to handle redirects #1901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
+ Coverage 97.65% 97.83% +0.18%
==========================================
Files 105 105
Lines 6786 6803 +17
==========================================
+ Hits 6627 6656 +29
+ Misses 86 80 -6
+ Partials 73 67 -6
Continue to review full report at Codecov.
|
gmlewis
requested changes
Jun 18, 2021
There was a problem hiding this comment.
Please add the missing line and also add a test that runs through the code with a redirect.
See https://github.com/google/go-github/blob/master/github/repos_contents_test.go#L668-L693 for inspiration.
gmlewis
requested changes
Jul 4, 2021
gmlewis
added
the
Breaking API Change
xun-guo-anzx
added a commit
to xun-guo-anzx/terraform-provider-github
that referenced
this pull request
Aug 18, 2021
go-github released the Go client library to [38.1.0][1] recently. API changes includes: * Add ListOptions required by GetCommit method. As described in change[2] * Add followRedirects required by GetBranch method and set it to false as start point. As described in change[3] [1]: https://github.com/google/go-github/releases/tag/v38.1.0 [2]: google/go-github#1960 [3]: google/go-github#1901
xun-guo-anzx
added a commit
to xun-guo-anzx/terraform-provider-github
that referenced
this pull request
Sep 6, 2021
go-github released the Go client library to [38.1.0][1] recently. API changes includes: * Add ListOptions required by GetCommit method. As described in change[2] * Add followRedirects required by GetBranch method and set it to false as start point. As described in change[3] [1]: https://github.com/google/go-github/releases/tag/v38.1.0 [2]: google/go-github#1960 [3]: google/go-github#1901
xun-guo-anzx
added a commit
to xun-guo-anzx/terraform-provider-github
that referenced
this pull request
Sep 6, 2021
go-github released the Go client library to [38.1.0][1] recently. API changes includes: * Add ListOptions required by GetCommit method. As described in change[2] * Add followRedirects required by GetBranch method and set it to false as start point. As described in change[3] [1]: https://github.com/google/go-github/releases/tag/v38.1.0 [2]: google/go-github#1960 [3]: google/go-github#1901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new followRedirects param for handling redirects on the GetBranch API. If redirected, the
response.Request.URLwill contain the redirected URL.As per: #1895.