Skip to content

Adds test cases for JSON resource marshalling #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2021
Merged

Adds test cases for JSON resource marshalling #1911

merged 3 commits into from
Jun 24, 2021

Conversation

sagar23sj
Copy link
Contributor

@sagar23sj sagar23sj commented Jun 23, 2021 •
edited
Loading

Resources Covered :

  • TaskStep
  • WorkflowJob
  • Jobs

Helps with issue : #55

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1911 (110ea20) into master (75644ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1911   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6786     6786           
=======================================
  Hits         6627     6627           
  Misses         86       86           
  Partials       73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75644ea...110ea20. Read the comment docs.

gmlewis
gmlewis approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sagar23sj !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp June 23, 2021 11:55
wesleimp
wesleimp approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 24, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit eb2b7f4 into google:master Jun 24, 2021
@gmlewis gmlewis mentioned this pull request Jun 26, 2021
Merged
gmlewis pushed a commit that referenced this pull request Jul 8, 2021
@sagar23sj @gmlewis
Adds test cases for JSON resource marshalling (#1911)
def222d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@wesleimp wesleimp wesleimp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagar23sj @gmlewis @wesleimp