Skip to content

Add test cases for JSON resource marshaling #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

Add test cases for JSON resource marshaling #1991

merged 1 commit into from
Jul 13, 2021

Conversation

sagar23sj
Copy link
Contributor

Resources Covered :

  • GetAuditLogOptions
  • HookConfig
  • AuditEntry

Helps with issue: #55

@sagar23sj
Resources Covered :
4887dcc 
- GetAuditLogOptions
- HookConfig
- AuditEntry
@codecov
Copy link

codecov bot commented Jul 12, 2021 •
edited
Loading

Codecov Report

Merging #1991 (4887dcc) into master (f47f8fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1991   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files         105      105           
  Lines        6809     6809           
=======================================
  Hits         6662     6662           
  Misses         80       80           
  Partials       67       67
Impacted Files Coverage Δ
github/checks.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47f8fe...4887dcc. Read the comment docs.

gmlewis
gmlewis approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sagar23sj !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp July 12, 2021 20:46
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 13, 2021

@googlebot - please do your thing.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 13, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 13, 2021

Thanks. 😄

@sagar23sj
Copy link
Contributor Author

haha 🤣

Parker77
Parker77 approved these changes Jul 13, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit 815cce1 into google:master Jul 13, 2021
@gmlewis gmlewis mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

+1 more reviewer

@Parker77 Parker77 Parker77 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagar23sj @gmlewis @Parker77