Skip to content

Conversation

x4b1
Copy link
Contributor

@x4b1 x4b1 commented Nov 22, 2021

This Pull request Adds a new function to delete workflows run from workflow history. The same functionality as this button:
Screenshot 2021-11-22 at 11 43 41

I cannot reference the documentation in the function comment because is missing the endpoint in the docs

@google-cla google-cla bot added the cla: no label Nov 22, 2021
@x4b1 x4b1 force-pushed the actions/workflows/runs/delete branch from 3deebc4 to 94072a5 Compare November 22, 2021 10:47
@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #2207 (432a561) into master (b26fa8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2207   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files         112      112           
  Lines       10036    10044    +8     
=======================================
+ Hits         9815     9823    +8     
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26fa8f...432a561. Read the comment docs.

Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xabi93 !
Just one tweak, please, then we will be ready for a second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp November 22, 2021 12:29
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@x4b1
Copy link
Contributor Author

x4b1 commented Nov 22, 2021

@gmlewis done!! 😅

@x4b1 x4b1 requested a review from gmlewis November 22, 2021 13:14
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xabi93 !
LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo (we don't have to wait for anyone in particular... all contributors are welcome to participate).

Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@gmlewis
Copy link
Contributor

gmlewis commented Nov 26, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 59e8a37 into google:master Nov 26, 2021
@x4b1 x4b1 deleted the actions/workflows/runs/delete branch November 27, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants