Skip to content

Conversation

kkaresz-tw
Copy link
Contributor

@kkaresz-tw kkaresz-tw commented Apr 18, 2023

The workflow_job events contain the branch information (head_branch) but it's missing from the WorkflowJob object. This change adds the missing field and updates the corresponding tests.

Fixes: #2762.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kkaresz-tw !
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #2764 (50e1105) into master (a888f0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2764   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11638    11638           
=======================================
  Hits        11412    11412           
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/actions_workflow_jobs.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis merged commit 9385ab0 into google:master Apr 18, 2023
@kkaresz-tw kkaresz-tw deleted the add-branch-to-workflow-job-event branch April 18, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HeadBranch is missing from WorkflowJob
2 participants