Skip to content

Conversation

dmitshur
Copy link
Member

@dmitshur dmitshur commented Apr 9, 2016

Note: GetByID uses the undocumented GitHub API endpoint /repositories/:id.

Include license preview Accept header.

Helps #329.

This commit is based on https://github.com/sourcegraph/go-github/commit/da394ef1f53de34e9c3e5782ca27589df32b426c which has been tested in production. It has been amended by me to include Licences API header, improved documentation and commit message, with appropriate updates to the test.

I've tested it locally with the Licences API header to make sure it works, and I've confirmed that it did.

Note: GetByID uses the undocumented GitHub API endpoint /repositories/:id.

Include license preview Accept header.

Helps #329.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@dmitshur
Copy link
Member Author

dmitshur commented Apr 9, 2016

@sqs, can you confirm you're okay with this commit being contributed to Google?

@sqs
Copy link
Contributor

sqs commented Apr 9, 2016

👍

@sqs
Copy link
Contributor

sqs commented Apr 9, 2016

I confirm.

@dmitshur
Copy link
Member Author

dmitshur commented Apr 9, 2016

@googlebot, can you check again?

@willnorris
Copy link
Collaborator

"need author consent" is a terminal CLA state. It will never automatically come out of this state; don't worry about it.

@willnorris willnorris merged commit 8f139c8 into google:master Apr 9, 2016
willnorris pushed a commit that referenced this pull request Apr 9, 2016
Note: GetByID uses the undocumented GitHub API endpoint /user/:id.

Resolves #329 (assuming #332 is also merged).
Closes #333
@dmitshur dmitshur deleted the add-RepositoriesService.GetByID branch April 9, 2016 18:40
@dmitshur
Copy link
Member Author

dmitshur commented Apr 9, 2016

Thanks!

@willnorris
Copy link
Collaborator

Thank you guys. This will actually be pretty useful inside Google as well, so I'm glad to see this added.

dmitshur pushed a commit that referenced this pull request Jul 1, 2017
Note: OrganizationService.GetByID uses the undocumented GitHub API
endpoint /organizations/:id.

Change all GetByID tests to fail early with t.Fatalf when error is returned.

Updates #329.
Follows #332 and #333.
nbareil pushed a commit to nbareil/go-github that referenced this pull request May 1, 2018
Note: OrganizationService.GetByID uses the undocumented GitHub API
endpoint /organizations/:id.

Change all GetByID tests to fail early with t.Fatalf when error is returned.

Updates google#329.
Follows google#332 and google#333.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants