chore: Replace http.Method* constants with string literals #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all usages of http.Method* constants to use string literals for HTTP methods (e.g., "GET", "POST", etc.) throughout the codebase. Added forbidigo linter to enforce this rule and updated .golangci.yml accordingly. This change aligns with new linting requirements and ensures consistency in HTTP method usage.
gmlewis
reviewed
Aug 23, 2025
gmlewis
approved these changes
Aug 23, 2025
alexandear
approved these changes
Aug 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3696 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 187 187
Lines 16640 16640
=======================================
Hits 15164 15164
Misses 1291 1291
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you, @jferrl and @alexandear! |
|
@jferrl - I apologize - I spoke too soon. I forgot that another PR added |
Moved forbidigo linter rules to the main settings section for better organization and clarity. No changes to the actual forbidden patterns or messages.
|
Fixes: #3695. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all usages of http.Method* constants to use string literals for HTTP methods (e.g., "GET", "POST", etc.) throughout the codebase. Added forbidigo linter to enforce this rule and updated .golangci.yml accordingly. This change aligns with new linting requirements and ensures consistency in HTTP method usage.