Skip to content

Conversation

joshlarsen
Copy link
Contributor

This PR adds ClientID to the Installation type.

Last year, GitHub added support for using the app ClientID to simplify the installation token flow. More detail in this blog post.

The test cases that involve Installation are also updated.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joshlarsen!
LGTM.

Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).

NOTE TO SELF: Rename "add" => "Add" for PR title consistency in this repo.

@joshlarsen joshlarsen changed the title fix: add ClientID to Installation Add ClientID to Installation Sep 18, 2025
@joshlarsen joshlarsen changed the title Add ClientID to Installation feat: Add ClientID to Installation Sep 18, 2025
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.12%. Comparing base (eef4b66) to head (b3b4d11).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3712   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         187      187           
  Lines       16640    16640           
=======================================
  Hits        15164    15164           
  Misses       1291     1291           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title feat: Add ClientID to Installation feat: Add ClientID to Installation Sep 22, 2025
@gmlewis gmlewis changed the title feat: Add ClientID to Installation feat: Add ClientID to Installation Sep 22, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 22, 2025

@joshlarsen - I apologize, but could you please re-run step4 to update the auto-generated files and push the changes to this PR? Thank you!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joshlarsen!
LGTM.
Merging.

@gmlewis gmlewis merged commit ffc5df8 into google:master Sep 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants