-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add ClientID
to Installation
#3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ClientID
to Installation
#3712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joshlarsen!
LGTM.
Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).
NOTE TO SELF: Rename "add" => "Add" for PR title consistency in this repo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3712 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 187 187
Lines 16640 16640
=======================================
Hits 15164 15164
Misses 1291 1291
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ClientID
to Installation
ClientID
to InstallationClientID
to Installation
@joshlarsen - I apologize, but could you please re-run step4 to update the auto-generated files and push the changes to this PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joshlarsen!
LGTM.
Merging.
This PR adds
ClientID
to theInstallation
type.Last year, GitHub added support for using the app
ClientID
to simplify the installation token flow. More detail in this blog post.The test cases that involve
Installation
are also updated.