feat: Support roles field in SCIM #3728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3728 +/- ##
=======================================
Coverage 91.11% 91.12%
=======================================
Files 187 187
Lines 16686 16686
=======================================
+ Hits 15204 15205 +1
+ Misses 1295 1294 -1
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jalseth
force-pushed
the
jalseth/ent-role
branch
from
51f8eb6 to
81c1ce9
Compare
GHES supports setting enterprise-wide role grants via the SCIM API. This can be used to grant enterprise owner, billing manager, etc. Signed-off-by: James Alseth <jalseth@google.com>
jalseth
force-pushed
the
jalseth/ent-role
branch
from
81c1ce9 to
a8fe10b
Compare
gmlewis
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Thank you, @jalseth!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell and/or @alexandear, might you have time for a code review? Thank you!
|
Thank you, @stevehipwell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHES supports setting enterprise-wide role grants via the SCIM API. This can be used to grant enterprise owner, billing manager, etc.