Bugfix - Go 1.6 reflect embedded unexported field access #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipping it when walking over values in an struct, to make sure that we don't skip validly accessible (exported) embedded values in an unexported field. This new checking logic is the new recommended strategy for reflective struct walking as of the Go 1.6 release. Related/References: - Go 1.6 reflect release note: https://golang.org/doc/go1.6#reflect - Issue: https://golang.org/issue/12367 (golang/go#12367) - CL: https://golang.org/cl/14085 (https://go-review.googlesource.com/#/c/14085/) - Commit: golang/go@afe9837
|
this test doesn't seem to properly exercise this. I installed go1.6 and run the test without the change to |
|
Strange, it's working for me:
|
|
oops, you're right. I was testing the wrong thing. Looks great! |
|
Ha, no problem. I've done the same before. 😜 |
|
Thanks for the merge! 😃 |
Rican7
deleted the
bugfix/go-1.6-reflect-embedded-unexported-field-access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incompatibility introduced in Go 1.6.
This PR updates the reflective struct walking in the
reflectValue()method to check if a field is not anonymous before skipping it, making sure that we don't skip validly accessible (exported) embedded values in an unexported field.This new checking logic is the new recommended strategy for reflective struct walking as of the Go 1.6 release.
Related/References:
(reflect: resolve incompatibility between gc and gccgo for unexported embedded structs golang/go#12367)
(https://go-review.googlesource.com/#/c/14085/)