-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #28 Fix, check for tika.jar #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! One suggestion, otherwise looks good.
tika/server.go
Outdated
//Check if the jar file exists | ||
_, err := os.Stat(jar) | ||
if os.IsNotExist(err) { | ||
return nil, fmt.Errorf("jar file [%s] does not exist", jar) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Check if the jar file exists | |
_, err := os.Stat(jar) | |
if os.IsNotExist(err) { | |
return nil, fmt.Errorf("jar file [%s] does not exist", jar) | |
} | |
// Check if the jar file exists. | |
if _, err := os.Stat(jar); os.IsNotExist(err) { | |
return nil, fmt.Errorf("jar file %q does not exist", jar) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experia help u
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Networking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help time spend with you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
//Check if the jar file exists _, err := os.Stat(jar) if os.IsNotExist(err) { return nil, fmt.Errorf("jar file [%s] does not exist", jar) } // Check if the jar file exists. if _, err := os.Stat(jar); os.IsNotExist(err) { return nil, fmt.Errorf("jar file %q does not exist", jar) }
Networking events across your
No description provided.