Skip to content

Avoid tsan issue in the paging test. #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Avoid tsan issue in the paging test. #699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion UnitTests/GTLRServiceTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,12 @@ - (void)testService_SingleQuery_Paging {
service.fetcherService.testBlock = ^(GTMSessionFetcher *fetcherToTest,
GTMSessionFetcherTestResponse testResponse) {
checkRequestParamsAndHeaders(fetcherToTest.request);
XCTAssertEqual(queryTicket.pagesFetchedCounter, (NSUInteger)pageCounter);
// There's a chance the test block will get calls at the same time as the query is being
// started, so there could a a race for access to `queryTicket`, so skip inspecing it
// for the first page.
if (pageCounter != 0) {
XCTAssertEqual(queryTicket.pagesFetchedCounter, (NSUInteger)pageCounter);
}

++pageCounter;

Expand Down