Skip to content

WIP: Change IPv4 to Ipv4 before interpetting it as camel case. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2018
Merged

WIP: Change IPv4 to Ipv4 before interpetting it as camel case. #669

merged 1 commit into from
Apr 17, 2018

Conversation

mattwhisenhunt
Copy link
Contributor

I found the bug, I am not familiar enough Ruby to make the fix idiomatic and I haven't looked for other acronym edge cases yet.
CC @Temikus

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2018
@coveralls
Copy link

coveralls commented Apr 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 95.997% when pulling 9b07d50 on mattwhisenhunt:fix-IPv4 into 4dd1813 on google:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 95.997% when pulling 9b07d50 on mattwhisenhunt:fix-IPv4 into 4dd1813 on google:master.

@theacodes theacodes merged commit 5e38f38 into googleapis:master Apr 17, 2018
@mattwhisenhunt mattwhisenhunt mentioned this pull request Apr 18, 2018
Closed
@djberg96 djberg96 mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattwhisenhunt @coveralls @theacodes @googlebot