Skip to content

Note change to normalize_unicode #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2018
Merged

Note change to normalize_unicode #685

merged 1 commit into from
Jun 5, 2018

Conversation

mattwhisenhunt
Copy link
Contributor

Fixes #684.

@Temikus

@mattwhisenhunt mattwhisenhunt requested a review from sqrrrl June 4, 2018 21:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2018
@coveralls
Copy link

coveralls commented Jun 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 95.997% when pulling 7ff2afd on mattwhisenhunt:fix-migrating into 42ae732 on google:master.

Temikus
Temikus reviewed Jun 4, 2018
View reviewed changes
MIGRATING.md
```ruby
ClientOptions.default.normalize_unicode = true
```
To restore the previous behavior, use the `normalize_unicode` request option.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mattwhisenhunt mattwhisenhunt merged commit 4e34ea4 into googleapis:master Jun 5, 2018
@mattwhisenhunt mattwhisenhunt deleted the fix-migrating branch June 5, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Temikus Temikus Temikus left review comments

@sqrrrl sqrrrl sqrrrl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattwhisenhunt @coveralls @sqrrrl @Temikus @googlebot