Skip to content

Conversation

kyoshidajp
Copy link

Hi all.

This fix #537.

I think launchy should be included in gemspec.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2018
@coveralls
Copy link

coveralls commented Jun 5, 2018

Coverage Status

Coverage remained the same at 95.997% when pulling df9fe8f on kyoshidajp:include_launchy_to_gemspec into 064b55c on google:master.

@dazuma
Copy link
Contributor

dazuma commented Dec 4, 2018

The InstalledAppFlow is not really part of the library, but is a convenience tool for certain test cases. It probably does not actually belong in the lib directory. We can't remove it without potential breakage so it's marked deprecated.

We'll fix #537 a different way by rescuing the LoadError, and documenting the launchy dependency explicitly. But we don't want to add launchy as an actual dependency, since it's not related to the library itself.

@dazuma dazuma closed this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google::APIClient::InstalledAppFlow depends on gems in development group
4 participants