Skip to content

Fixes for HttpClient 4.5.1 support #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Fixes for HttpClient 4.5.1 support #312

wants to merge 11 commits into from

Conversation

jarrodhroberson
Copy link

This is a cleaner solution as the other pull request I sent really didn't do anything other than eliminate the exception and it should be assumed that I have configured the HttpClient like I want.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@lesv
Copy link
Contributor

lesv commented Mar 14, 2018

Thanks for the contribution. There appears to be a merge conflict so I'm going to close.

@lesv lesv closed this Mar 14, 2018
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
* Add lint test and com.coveo:fmt-maven-plugin configuration

* Run the formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants