Skip to content

Do not rely on a color term crate to generate ANSI character #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

Do not rely on a color term crate to generate ANSI character #267

merged 1 commit into from
Jul 19, 2023

Conversation

bjacotg
Copy link
Collaborator

@bjacotg bjacotg commented Jul 18, 2023

Do not rely on a ANSI crate but just use the ANSI character hardcoded.

  • ansi-term is not maintained anymore
  • nu-ansi-term requires a Rust version higher than our current minimum version
  • overall, we are not doing anything too fancy with colors.
    • this may change in the future, which can lead to the need for a crate which would support our requirements.

@bjacotg bjacotg marked this pull request as ready for review July 18, 2023 15:12
@copybara-service copybara-service bot merged commit 981021e into main Jul 19, 2023
@bjacotg bjacotg mentioned this pull request Jul 19, 2023
Closed
@gribozavr gribozavr deleted the no-color-crate branch February 17, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bjacotg