Add more uninterruptible methods

[gissuebot]

Original issue created by Ash2kk on 2013-05-12 at 10:33 AM

---

Currently Uninterruptibles have putUninterruptibly() and takeUninterruptibly() methods for BlockingQueue. Consider adding helper methods for other interruptible methods: offer(Object, long, TimeUnit) and poll(long, TimeUnit).

Also there is BlockingDeque interface with many more interruptible methods.

Related to issue #1212 and issue #1315.

[RamAnvesh]

Also there are the Object.wait methods. I am guessing they are also used quite frequently.

[camerondavison]

is there a reason that poll or offer has not been added? do they introduce something that will make people program incorrectly? such as #1118 ?

[cpovirk]

I think we just haven't needed them yet. They seem fine to add as far as I can tell.

[thecoop]

Could this be made more generic, for running any arbitrary operation that throws InterruptedException?

Uninterruptibles.runUninterruptibly(() -> opThrowingInterruptedException())

[RamAnvesh]

@thecoop #2384

[leventov]

Maybe there are enough voices to add more methods now? We would benefit from BlockingQueue.offer() and poll() too.

[Pr0methean]

@thecoop For time-limited operations, we'd need to pass the total time into the helper method, which in turn would pass the remaining time as an argument to the functional parameter.

[tanmayvarun]

@cpovirk l am beginner when it comes to contributing to open-source of Guava. I would like to work on this issue.

I am planning to implement two methods offerUninterruptibly(long timeout, TimeUnit unit) and pollUninterruptibly(long timeout, TimeUnit unit).

Please let me know if I can start working on this!

Thanks

[cpovirk]

That sounds great. Go for it!

(I have some other things that I need to get back to people about, so I might not review it immediately, but I'll be sure to get to it.)

[tanmayvarun]

Ack.

[tanmayvarun]

@cpovirk Please review per your convenience.

[tanmayvarun]

All errors fixed, Please review 4034

[tanmayvarun]

@cpovirk Please suggest me next issue to work on, a small feature enhancement will be good too :)

[cpovirk]

Possibilities:

• No Provider in OSGI info #3504
• Stop using LinkedList in TrieParser and most of our tests #2394
• Futures.addCallback should document what happens to exceptions thrown by the callback #2058

[tanmayvarun]

All errors fixed, Please review 4034

@cpovirk Any updates..