Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JDK18+ SecurityManager build failures (and maybe other failures on some older JDKs) #6245

Closed
cpovirk opened this issue Nov 16, 2022 · 2 comments · Fixed by #7102
Closed

Fix JDK18+ SecurityManager build failures (and maybe other failures on some older JDKs) #6245

cpovirk opened this issue Nov 16, 2022 · 2 comments · Fixed by #7102
Labels
P3 package=general type=defect Bug, not working as expected

Comments

@cpovirk
Copy link
Member

cpovirk commented Nov 16, 2022

See #6243.
@cpovirk cpovirk added type=defect Bug, not working as expected package=general P3 labels Nov 16, 2022
@cpovirk
Copy link
Member Author

cpovirk commented Dec 5, 2022

Also, JDK20 will make Thread.suspend throw, breaking AbstractFutureTest.testToString_delayedTimeout.

@cpovirk
Copy link
Member Author

cpovirk commented Dec 5, 2022

I just happened to see a reminder that we have some tests that we automatically skip under JDK9 and JDK10:

guava/guava-tests/test/com/google/common/base/FinalizableReferenceQueueClassLoaderUnloadingTest.java

Line 293 in f4c02a1

* These tests fail in JDK 9 and JDK 10 for an unknown reason. It might be the test; it might be

Apparently they work fine under JDK11+, unless I'm missing something.

@copybara-service copybara-service bot mentioned this issue Dec 5, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Dec 5, 2022
@cpovirk
Under JDK20+, skip test that uses Thread.suspend.
bf10177 
It [throws `UnsupportedOperationException`](https://bugs.openjdk.org/browse/JDK-8249627) under those versions.

(more work toward #6245)

PiperOrigin-RevId: 493001256
copybara-service bot pushed a commit that referenced this issue Dec 5, 2022
@cpovirk
Under JDK20+, skip test that uses Thread.suspend.
6f44d81 
It [throws `UnsupportedOperationException`](https://bugs.openjdk.org/browse/JDK-8249627) under those versions.

(more work toward #6245)

PiperOrigin-RevId: 493001256
copybara-service bot pushed a commit that referenced this issue Dec 5, 2022
@cpovirk
Under JDK20+, skip test that uses Thread.suspend.
fc0feab 
It [throws `UnsupportedOperationException`](https://bugs.openjdk.org/browse/JDK-8249627) under those versions.

(more work toward #6245)

PiperOrigin-RevId: 493001256
copybara-service bot pushed a commit that referenced this issue Dec 5, 2022
@cpovirk
Under JDK20+, skip test that uses Thread.suspend.
b2e3b0c 
It [throws `UnsupportedOperationException`](https://bugs.openjdk.org/browse/JDK-8249627) under those versions.

(more work toward #6245)

PiperOrigin-RevId: 493001256
Athish9090 referenced this issue Dec 5, 2022
@dependabot
Bump styfle/cancel-workflow-action from 0.9.1 to 0.10.0
a98c363 
Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.9.1 to 0.10.0.
- [Release notes](https://github.com/styfle/cancel-workflow-action/releases)
- [Commits](styfle/cancel-workflow-action@0.9.1...0.10.0)

---
updated-dependencies:
- dependency-name: styfle/cancel-workflow-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Closes #6092

RELNOTES=n/a
PiperOrigin-RevId: 460776493
copybara-service bot pushed a commit that referenced this issue Dec 5, 2022
@cpovirk
Under JDK20+, skip test that uses Thread.suspend.
ea49a6b 
It [throws `UnsupportedOperationException`](https://bugs.openjdk.org/browse/JDK-8249627) under those versions.

(more work toward #6245)

PiperOrigin-RevId: 493077898
@sgammon sgammon mentioned this issue Mar 8, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Mar 12, 2024
@sgammon
Make build and tests work with Java 21, and enable CI for them.
b5901b3 
The main changes is that tests need `-Djava.security.manager=allow`.

Fixes and closes #7065

Helps with #6790

Fixes #6245 (at least the remaining parts that we actually care about)

Fixes #7087

Signed-off-by: Sam Gammon <sam@elide.ventures>
RELNOTES=n/a
PiperOrigin-RevId: 614671411
@copybara-service copybara-service bot mentioned this issue Mar 12, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Mar 12, 2024
@sgammon
Make build and tests work with Java 21, and enable CI for them.
91ca36b 
The main changes is that tests need `-Djava.security.manager=allow`.

Fixes and closes #7065

Helps with #6790

Fixes #6245 (at least the remaining parts that we actually care about)

Fixes #7087

Signed-off-by: Sam Gammon <sam@elide.ventures>
RELNOTES=n/a
PiperOrigin-RevId: 614671411
copybara-service bot pushed a commit that referenced this issue Mar 12, 2024
@sgammon
Make build and tests work with Java 21, and enable CI for them.
8982c22 
The main changes is that tests need `-Djava.security.manager=allow`.

Fixes and closes #7065

Helps with #6790

Fixes #6245 (at least the remaining parts that we actually care about)

Fixes #7087

Signed-off-by: Sam Gammon <sam@elide.ventures>
RELNOTES=n/a
PiperOrigin-RevId: 614671411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 package=general type=defect Bug, not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make build and tests work with Java 21, and enable CI for them. google/guava
1 participant
@cpovirk