-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to create a copy of a Key with an annotation #1108
Conversation
Don't really think this is necessary. Trivial to do already: |
It was to provide the opposite of There's not a huge difference with changing the annotation, one just involves less duplication: If you don't think this is necessary, that's fine - feel free to close. |
ofType is slightly more necessary, as construction a new variant with a different type requires some branching (to deal with annotation instances vs annotation types). |
Personally, the discoverability here is at least a bit of a selling point. More than once I've looked for an |
if you think it's worth it extra methods, feel free to merge in. |
Any chance of this being pulled soon, @dimo414? |
Any chance of getting this in soon? 😺 |
Is there a chance of this getting in soon? |
I'll take a swing at it over the long weekend :) |
Thank you! 😄 |
…nt annotations. Closes #1108 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313246519
Thanks for the contribution, and your patience :) |
…nt annotations. Closes #1108 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313246519
…nt annotations. Closes google/guice#1108 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313246519
…nt annotations. Closes google/guice#1108 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313246519
This allows you to easily specify an annotation/annotation type to an existing key.