fsgofer: update lastUnlockedDentry only after unlocking the dentry #12151
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl809324448
branch
2 times, most recently
from
44bc49a to
b40d25c
Compare
Update lastUnlockedDentry only after the mutex has been unlocked. If doRevalidationLisafs panics, deferred functions are executed. Updating lastUnlockedDentry earlier could lead to a deferred function attempting to acquire an already locked mutex, resulting in a deadlock. PiperOrigin-RevId: 810075556
copybara-service
bot
force-pushed
the
test/cl809324448
branch
from
b40d25c to
efacb45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsgofer: update lastUnlockedDentry only after unlocking the dentry
Update lastUnlockedDentry only after the mutex has been unlocked. If
doRevalidationLisafs panics, deferred functions are executed. Updating
lastUnlockedDentry earlier could lead to a deferred function attempting to
acquire an already locked mutex, resulting in a deadlock.