Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing header files in j2objc 2.3 JRE.framework (android/icu/text/UForwardCharacterIterator.h) #1020

Closed
sarsonj opened this issue Dec 19, 2018 · 4 comments

Comments

@sarsonj
Copy link

@sarsonj sarsonj commented Dec 19, 2018

Hi,

we upgraded to j2objc 2.3. After clean recompile of our project we got compilation error related new support of Android ICU. It looks like, that some referenced header files are not included in JRE.framework. We are using precompiled zip file downloaded from j2objc site.

screenshot 2018-12-20 00 34 44

But there is no UForwardCharacterIterator.h in JRE.framework in android/icu/text/UForwardCharacterIterator.h.

Thanks,

Jindrich

@antonio-cortes-perez

This comment has been minimized.

Copy link
Member

@antonio-cortes-perez antonio-cortes-perez commented Dec 20, 2018

Hi,

I see, this class is hidden in the Android ICU version:
https://android.googlesource.com/platform/external/icu/+/oreo-release/android_icu4j/src/main/java/android/icu/text/UForwardCharacterIterator.java#58

But in our case, we should expose the header file because UCharacterIterator implements UForwardCharacterIterator.

In case I am missing something, your project should be using this new functionality somehow, maybe through a java.time class? Could you share the list (stack) of include files that lead to UCharacterIterator?

Thanks,
Antonio.

@sarsonj

This comment has been minimized.

Copy link
Author

@sarsonj sarsonj commented Dec 20, 2018

Hi,

I don't use any new functionality, but this happen when nothing more but using framework JRE provided by j2ObjC distribution:

@import JRE;

This UCharacterIterator.h is in JRE.framework, not in my generated code. And it references to non-existing file in this framework.

Have a nice day,
Jindrich

@antonio-cortes-perez

This comment has been minimized.

Copy link
Member

@antonio-cortes-perez antonio-cortes-perez commented Dec 20, 2018

Thanks for the additional details! I'll make sure the header is included in the next release. In the meantime, please copy the attached header (rename to .h)
UForwardCharacterIterator.txt

to the following locations inside the J2ObjC distribution folder:
include/android/icu/text/UForwardCharacterIterator.h
frameworks/JRE.framework/Versions/A/Headers/android/icu/text/UForwardCharacterIterator.h

antonio-cortes-perez added a commit that referenced this issue Jan 3, 2019
… UCharacterIterator implements it.

	Change on 2018/12/20 by antoniocortes <antoniocortes@google.com>

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=226354958
@antonio-cortes-perez

This comment has been minimized.

Copy link
Member

@antonio-cortes-perez antonio-cortes-perez commented Jan 11, 2019

Fixed in 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.