Issue #2388: Fixed translation of Java 16+ pattern matching in instanceof expressions within if statements.
#2571
+343
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_812930294
branch
2 times, most recently
from
c24673b to
3ddd4d5
Compare
…nceof` expressions within `if` statements. This change introduces a `needsCastChk` flag to `CastExpression` to prevent redundant runtime cast checks. When translating `if (expr instanceof Type var)`, a local variable `var` is declared and initialized with a cast of `expr`. Since the `instanceof` check already guarantees type safety, the generated cast does not need an additional runtime check. For complex conditions like `if (expr instanceof Type var && otherCondition)`, the translation now creates a nested `if` statement for `otherCondition` inside the block where `var` is in scope. PiperOrigin-RevId: 813986197
copybara-service
bot
force-pushed
the
test_812930294
branch
from
3ddd4d5 to
6a1c87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2388: Fixed translation of Java 16+ pattern matching in
instanceofexpressions withinifstatements.This change introduces a
needsCastChkflag toCastExpressionto prevent redundant runtime cast checks. When translatingif (expr instanceof Type var), a local variablevaris declared and initialized with a cast ofexpr. Since theinstanceofcheck already guarantees type safety, the generated cast does not need an additional runtime check. For complex conditions likeif (expr instanceof Type var && otherCondition), the translation now creates a nestedifstatement forotherConditioninside the block wherevaris in scope.