Instead of calling Subject.actual(), store the actual value in a field, and read that. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, and read that. actual() is being removed. While there, upgrade to Truth 0.44. The upgade isn't necessary for the actual() migration, but it should reduce the chance that we end up using other methods that are later removed.
|
LGTM. |
|
Thanks! A question for you: I'd like to import this library (with my merged change) version back into the Google depot, as it's blocking the removal of |
|
I'll cut a new release and import to third_party. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actual() is being removed.
While there, upgrade to Truth 0.44. The upgade isn't necessary for the actual() migration, but it should reduce the chance that we end up using other methods that are later removed.