-
Notifications
You must be signed in to change notification settings - Fork 218
Unmarshal struct attributes #163
Conversation
dd0a062
to
fdb29a2
Compare
fdb29a2
to
363160e
Compare
@shwoodard What needs to happen for this PR to be merged? It appears to fix issues #156 and #164. I confess that there are subtle issues involved that I don't fully grasp. But, I believe I want to use the fixes of this PR instead of relying on a commit from March before the unmarshaling issues were introduced. |
Any news on this PR ? Why cannot it be merged ? |
I would also like to see this merged if possible. I am in agreement with @mkarlesky in the sense that I don't grasp some of the subtle issues, but I think this is an important feature to have. |
@shwoodard @aren55555 @Slemgrim can one of you provide a status update on this issue? What are the blockers to merging? What's missing / doesn't work as expected / etc? EDIT: I just tested this and it didn't really do what I hoped/expected. I have a struct generated by gogo proto that looks like
Normally protobuf's jsonpb marshaller will automatically serialize So I tried writing a custom marshaller like
But that's never even called by the current version of I stepped through the debugger and see that its now trying to treat I ended up on this PR because of #156 but this doesn't seem to be related, or the PR doesn't really work, or I'm doing something wrong, or all of the above. But I thought I'd share what I was trying/looking for while I'm here. :) |
Add the ability to marhsal and unmarhsal custom struct attributes as well custom struct slices, either pointers or not