RFC 3339 support for both Marshal and Unmarshal. #204

aren55555 · 2021-04-05T01:07:49Z

Builds upon #201.

# Conflicts: # constants.go # models_test.go # request_test.go

aren55555 · 2021-04-05T01:24:13Z

@quetzyg please take a quick peek and let me know what you think! This builds upon what @omarismail submitted in #201 (which I reverted yesterday in #202, due to missing the Serialization/Marshaling part, which I've now added)

quetzyg

Looks good, just left a few comments/suggestions.

request_test.go

request.go

response_test.go

Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com>

google-cla · 2021-04-05T17:25:54Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-05T17:25:54Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-05T17:30:04Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com>

google-cla · 2021-04-05T17:37:28Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-05T17:37:28Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

aren55555 · 2021-04-05T17:52:33Z

@googlebot I fixed it, @quetzyg was the author of the code and has accepted the CLA. The commits were with the email quetzy.garcia@i*******e.com which is @quetzyg.

google-cla · 2021-04-05T17:52:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

quetzyg · 2021-04-05T17:59:11Z

Want me to sign CLA again @aren55555 ?

aren55555 · 2021-04-05T17:59:47Z

@quetzyg if possible yes please, would make my life a tad bit easier! You need to sign it with quetzy.garcia@i*******e.com

…use time.RFC3339 directly.

google-cla · 2021-04-05T18:06:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

quetzyg · 2021-04-05T18:11:55Z

@aren55555 I've added my other email, so it should be sorted now.

aren55555 · 2021-04-05T18:12:20Z

@googlebot rescan plz

* RFC 3339 support for both Marshal and Unmarshal. * Post merge cleanup * Update request_test.go Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * Spelling * Update request.go Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat use time.RFC3339 directly. Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com>

* Revert "Add RFC3339 timestamp (google#201)" (google#203) This reverts commit c0ee6d2. * RFC 3339 support for both Marshal and Unmarshal. (google#204) * RFC 3339 support for both Marshal and Unmarshal. * Post merge cleanup * Update request_test.go Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * Update request.go Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat use time.RFC3339 directly. Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * go mod init (google#205) * parent 89dd8d2 author Omar Ismail <oismail91@gmail.com> 1618325394 -0400 committer Omar Ismail <oismail91@gmail.com> 1618326429 -0400

* RFC 3339 support for both Marshal and Unmarshal. * Post merge cleanup * Update request_test.go Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * Spelling * Update request.go Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com> * Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat use time.RFC3339 directly. Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com>

aren55555 added 3 commits April 4, 2021 18:06

RFC 3339 support for both Marshal and Unmarshal.

f4bf036

Merge branch 'master' into aren55555/rfc3339/fix

5964bfe

# Conflicts: # constants.go # models_test.go # request_test.go

Post merge cleanup

6a4c8f0

This was referenced Apr 5, 2021

Add RFC3339 timestamp #201

Merged

int64 id value changed while decoding #202

Open

quetzyg approved these changes Apr 5, 2021

View reviewed changes

request_test.go Show resolved Hide resolved

request_test.go Outdated Show resolved Hide resolved

request.go Outdated Show resolved Hide resolved

response_test.go Show resolved Hide resolved

Update request_test.go

9559676

Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com>

Spelling

1886621

Update request.go

05878cd

Co-authored-by: Quetzy Garcia <quetzy.garcia@integrate.com>

Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat …

97e3c1f

…use time.RFC3339 directly.

aren55555 merged commit f3b4acf into google:master Apr 5, 2021

omarismail mentioned this pull request Apr 13, 2021

Add missing RFC3339 to response, add tests hashicorp/jsonapi#5

Closed

omarismail mentioned this pull request Apr 13, 2021

Match upstream (google/jsonapi) hashicorp/jsonapi#7

Merged

RFC 3339 support for both Marshal and Unmarshal. #204

RFC 3339 support for both Marshal and Unmarshal. #204

Uh oh!

Conversation

aren55555 commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aren55555 commented Apr 5, 2021

Uh oh!

quetzyg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

aren55555 commented Apr 5, 2021

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

quetzyg commented Apr 5, 2021

Uh oh!

aren55555 commented Apr 5, 2021

Uh oh!

google-cla bot commented Apr 5, 2021

Uh oh!

quetzyg commented Apr 5, 2021

Uh oh!

aren55555 commented Apr 5, 2021

Uh oh!

Uh oh!

aren55555 commented Apr 5, 2021 •

edited

Loading