New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subtests. Need to stob building on go < 1.7. #63

Merged
merged 2 commits into from Feb 17, 2017

Conversation

Projects
None yet
2 participants
@thedodd
Contributor

thedodd commented Jan 20, 2017

note

This PR is based on google/jsonapi#38. Once it is merged into master, this PR will be rebased. There is only one commit unique to this PR.

@thedodd

This comment has been minimized.

Show comment
Hide comment
@thedodd

thedodd Jan 23, 2017

Contributor

After #38 is merged, I will rebase this one and it should resolve any conflicts.

Contributor

thedodd commented Jan 23, 2017

After #38 is merged, I will rebase this one and it should resolve any conflicts.

@@ -1,6 +1,5 @@
language: go
go:
- 1.6.x

This comment has been minimized.

@thedodd

thedodd Feb 2, 2017

Contributor

Subtests were introduced in 1.7, so we can not use 1.6 in tests now.

@thedodd

thedodd Feb 2, 2017

Contributor

Subtests were introduced in 1.7, so we can not use 1.6 in tests now.

This comment has been minimized.

@aren55555

aren55555 Feb 2, 2017

Collaborator

I think 1.6 should be supported until 1.8 is released (any day now).

@aren55555

aren55555 Feb 2, 2017

Collaborator

I think 1.6 should be supported until 1.8 is released (any day now).

This comment has been minimized.

@thedodd

thedodd Feb 17, 2017

Contributor

1.8 has dropped. We should be good to go on this now.

@thedodd

thedodd Feb 17, 2017

Contributor

1.8 has dropped. We should be good to go on this now.

@aren55555 aren55555 merged commit bce7629 into google:master Feb 17, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment