This repository was archived by the owner on Sep 4, 2025. It is now read-only.
Use subtests. Need to stob building on go < 1.7. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedodd
force-pushed
the
subtests
branch
2 times, most recently
from
44f2cab to
1e30be0
Compare
|
After #38 is merged, I will rebase this one and it should resolve any conflicts. |
thedodd
commented
Feb 2, 2017
| @@ -1,6 +1,5 @@ | |||
| language: go | |||
| go: | |||
| - 1.6.x | |||
There was a problem hiding this comment.
Subtests were introduced in 1.7, so we can not use 1.6 in tests now.
There was a problem hiding this comment.
I think 1.6 should be supported until 1.8 is released (any day now).
There was a problem hiding this comment.
1.8 has dropped. We should be good to go on this now.
aren55555
approved these changes
Feb 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
This PR is based on #38. Once it is merged into master, this PR will be rebased. There is only one commit unique to this PR.