Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

angelospanag
Copy link
Contributor

The current response examples in the README are returning content-type in headers: text/plain; charset=UTF-8.

In order to return a proper JSON API content-type application/vnd.api+json, the following lines should be reversed:

	w.WriteHeader(http.StatusCreated)
	w.Header().Set("Content-Type", jsonapi.MediaType)

to:

	w.Header().Set("Content-Type", jsonapi.MediaType)
	w.WriteHeader(http.StatusCreated)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@angelospanag
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@aren55555 aren55555 merged commit af3dab1 into google:master Apr 5, 2017
@angelospanag angelospanag deleted the fix/update_documentation_headers_response branch April 5, 2017 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants