Adding volumes, configmaps, secrets and certificates and restructuring the code again #128
Conversation
…ows more meaningful informations about the objects.
…st path of the persistent volumes. Changed status fields as well but didn't implement them yet.
…nction in the challenge_controller.go. Also, fixed a problem with pow and create a package for status.
…m namespace. Also, implemented ManagedCertificate.
…allenge namespace. Also, fixed a condition for creating the certificate.
…rator. Also, created a samples folder for CR samples. Updated operator.yaml and uncommented the rest of the configurations in the deployment.
There was a problem hiding this comment.
Overall LGTM, see my comments.
I think that using ConfigMap for powDifficulty is a bit of over-engineering but I understand that this is not smth you developed, you just migrated it from the Makefile. I think the problem is as simple as "propagating an integer from config into a container" and should be solved by adding the ENV variable into Pod. That would require though to change pow script to read the ENV instead of the file here: https://github.com/google/kctf/blob/alpha/base/nsjail-docker/files/proof_of_work/maybe_pow.sh#L21.
But that is probably better for separate Issue/PR. This one is working and that's okay 👍
…fying description of this field.
I think the only downside of that is that we need to restart the deployment for it to take effect? |
Now, all the expected functionalities work: volumes, pow, deployment, service, ingress, certificate, secrets, etc.
About the secrets, I decided to create them in the kube-system and then copy them to other namespaces.
I added as well two new fields in the CRD: domainName and replicas.
Also, made some changes in the structure of the code, by passing the update functions to each package, so we have always a set of functions for the packages, unless one/some of them is/are unnecessary: create, delete, generate, isEqual and Update.
But it's still necessary to: finish the implementation of the status and maybe add others status; change the scripts; and finally add documentation.