Revert PR: https://github.com/google/kf/pull/1049 #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR: google#1049 is breaking .net Core applications, where lower case environrment variables are expected. Proposing this change, before better fix is available
garethgeorge
approved these changes
Nov 15, 2023
|
Rolling back, please take care that without this fix you may be able to add duplicate values for a given env var using mixed case variable names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #1049 is breaking .net Core applications, where lower case environment variables are expected. Proposing this change, before better fix is available
Fixes #
Proposed Changes
Release Notes