Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove common prefixes. #166

Merged
merged 1 commit into from
Dec 12, 2022
Merged

remove common prefixes. #166

merged 1 commit into from
Dec 12, 2022
+9 −16

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Dec 11, 2022 •
edited
Loading

Overview

Removes common prefix behavior. This was somewhat weird, and now does not affect most of the current implementation.

CC @ZibingZhang

References

Blocked by

  • NA

@odashi odashi added this to the v0.3 milestone Dec 11, 2022
@odashi odashi merged commit 9823ed1 into main Dec 12, 2022
@odashi odashi deleted the remove-common-prefixes branch December 12, 2022 01:39
@odashi odashi mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZibingZhang ZibingZhang ZibingZhang approved these changes

@ShigekiKarita ShigekiKarita ShigekiKarita approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@odashi @ShigekiKarita @ZibingZhang