Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake version #14

Closed
facontidavide opened this issue Sep 9, 2019 · 1 comment · Fixed by #16
Closed

CMake version #14

facontidavide opened this issue Sep 9, 2019 · 1 comment · Fixed by #16

Comments

@facontidavide
Copy link

Hi,

I was trying to compile with CMake 3.5.2, but I got this error:

CMake Error at CMakeLists.txt:69 (list):
  list does not recognize sub-command FILTER

Apparently FILTER was introduced in version 3.6, but according to the CMakeLists.txt file, only version 2.8 is required.

https://github.com/google/marl/blob/master/CMakeLists.txt#L15

Can we remove FILTER to make this work with older versions of CMake?
ben-clayton added a commit to ben-clayton/marl that referenced this issue Sep 9, 2019
@ben-clayton
CMakeLists.txt: Use explicit file lists
76d2000 
Don't use GLOB and list FILTER.
globbing doesn't automatically scan new files, requiring cmake to be re-run every time a new file is added.
FILTER was apparently added in a moderately recent version of CMake, which not everyone has.

Fixes: google#14
@ben-clayton ben-clayton mentioned this issue Sep 9, 2019
Merged
@ben-clayton
Copy link
Contributor

Hi @facontidavide,

Thank you for your feedback. I've put together a change that should fix this (#16).
Please can you check to see if this works for you?

Many thanks,
Ben

ben-clayton added a commit that referenced this issue Sep 9, 2019
@ben-clayton
CMakeLists.txt: Use explicit file lists
d89fe34 
Don't use GLOB and list FILTER.
globbing doesn't automatically scan new files, requiring cmake to be re-run every time a new file is added.
FILTER was apparently added in a moderately recent version of CMake, which not everyone has.

Fixes: #14
@beimingxinghai beimingxinghai mentioned this issue Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMakeLists.txt: Use explicit file lists ben-clayton/marl
2 participants
@facontidavide @ben-clayton